Discussion:
Sponsor my "runescape" package version 0.4
Carlos Donizete Froes
2018-09-03 22:40:06 UTC
Permalink
Hi,

I have the package in 'mentors.d.n' a few weeks ago with some fixes from
the previous version of Debian.

Could someone upload this package?

https://mentors.debian.net/package/runescape

Thanks!
--
⢀⣴⠾⠻⢶⣦⠀ Carlos Donizete Froes [a.k.a coringao]
⣾⠁⢠⠒⠀⣿⡁ - https://wiki.debian.org/coringao
⢿⡄⠘⠷⠚⠋⠀ GPG: 4096R/B638B780
⠈⠳⣄⠀⠀⠀ 2157 630B D441 A775 BEFF D35F FA63 ADA6 B638 B780
Phil Morrell
2018-09-04 07:23:07 UTC
Permalink
Post by Carlos Donizete Froes
https://mentors.debian.net/package/runescape
As mentioned in that page, you need to remove " (Closes: #901485)" from
the changelog and re-upload to mentors. RFS bugs are closed by the DD
uploader, not the changelog (unlike ITP).
Carlos Donizete Froes
2018-09-04 10:06:59 UTC
Permalink
Hi Phil,
Post by Phil Morrell
As mentioned in that page, you need to remove " (Closes: #901485)" from
the changelog and re-upload to mentors. RFS bugs are closed by the DD
uploader, not the changelog (unlike ITP).
Removed (Closes: #901485) from d/changelog and re-uploaded for mentors.d.n.

Thanks!
--
⢀⣎⠟⠻⢶⣊⠀ Carlos Donizete Froes [a.k.a coringao]
⣟⠁⢠⠒⠀⣿⡁ - https://wiki.debian.org/coringao
⢿⡄⠘⠷⠚⠋⠀ GPG: 4096R/B638B780
⠈⠳⣄⠀⠀⠀ 2157 630B D441 A775 BEFF D35F FA63 ADA6 B638 B780
Markus Koschany
2018-09-07 20:43:24 UTC
Permalink
Hi,

I have uploaded your package a few minutes ago.

I have removed your changelog entry for version 0.3.1 because it was
never uploaded to Debian. Instead I tried to merge your entries with
version 0.4.

I noticed that you strictly depend on default-jre. This is usually fine
but might be too strict for people who use the Oracle JDK. Since your
package is in non-free anyway, you could relax this dependency and write
next time

default-jre | java8-runtime

and make it clear that you also support the Oracle Java 8 JDK (or later).

Regards,

Markus
Carlos Donizete Froes
2018-09-07 21:18:49 UTC
Permalink
Hi Markus,
Post by Markus Koschany
I noticed that you strictly depend on default-jre. This is usually fine
but might be too strict for people who use the Oracle JDK. Since your
package is in non-free anyway, you could relax this dependency and write
next time
default-jre | java8-runtime
and make it clear that you also support the Oracle Java 8 JDK (or later).
In this version of the package supports OpenJDK/Oracle Java Runtime version 9 or
later. OpenJDK/Oracle Java smaller than version 9 may not work. :/

I'll add 'default-jre | java9-runtime' soon.

Thanks!
--
⢀⣎⠟⠻⢶⣊⠀ Carlos Donizete Froes [a.k.a coringao]
⣟⠁⢠⠒⠀⣿⡁ - https://wiki.debian.org/coringao
⢿⡄⠘⠷⠚⠋⠀ GPG: 4096R/B638B780
⠈⠳⣄⠀⠀⠀ 2157 630B D441 A775 BEFF D35F FA63 ADA6 B638 B780
Loading...